Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Upgrade k8s dependencies to v1.13 #551

Merged
merged 2 commits into from
Jan 13, 2019

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Jan 12, 2019

What this PR does / why we need it:
This PR aims to upgrade k8s dependencies to latest version v1.13.2

  1. Add direct k8s dependencies in Gopkg.toml and upgrade them to v1.13.2. Client-go upgrades to v10.0 which is compatible with v1.13.2
  2. Use PodFilter from algorithm package.
  3. algorithm.NodeFieldSelectorKeyNodeName -> schedulerapi.NodeFieldSelectorKeyNodeName
  4. Update e2e test shell.
  5. Resolve upgrade conflicts. The only one I meet is github.com/imdario/mergo in k8s.io/client-go use newer version and I override it in Gopkg.toml and resolve conflicts.
    https://github.com/kubernetes/client-go/blob/release-10.0/Godeps/Godeps.json#L158
  6. leaderelection interface is changed, needs to pass context and use context.Done() to get channel object. Please review this change.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #542

Special notes for your reviewer:
separate this change into two commits. One for code change and the one for vendor updates.

Release note:

Upgrade k8s dependencies to v1.13.2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 12, 2019
@Jeffwan Jeffwan changed the title Upgrade k8s dependencies to v1.13.2 Upgrade k8s dependencies to v1.13 Jan 12, 2019
@k82cn
Copy link
Contributor

k82cn commented Jan 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 89c170a into kubernetes-retired:master Jan 13, 2019
@k82cn k82cn added this to the v0.4 milestone Jan 26, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade kuberentes version to 1.13
3 participants